davidrelich/nextcloud-notes-desktop-app
1
0
Fork 0
Code Pull Requests Actions Packages Projects Releases Activity

Fix bidirectional favorite sync - use timestamp matching in syncFavoriteStatus

Browse Source 
The syncFavoriteStatus method was using title matching which fails when
API and WebDAV titles differ. Now uses modified timestamp + category
matching (with title fallback) for reliable bidirectional sync.
This commit is contained in:
drelich
2026-03-26 09:18:26 +01:00
parent 244ba69eed
commit 8bbd5f9262
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/services/syncManager.ts
View File

@@ -143,17 +143,30 @@ export class SyncManager {
const apiMetadata = await this.api.fetchNotesMetadata();
const cachedNotes = await localDB.getAllNotes();
// Map API notes by title and category for matching
const apiMap = new Map<string, {id: number, favorite: boolean}>();
// Map API notes by modified timestamp + category for reliable matching
// (titles can differ between API and WebDAV)
const apiByTimestamp = new Map<string, {id: number, title: string, favorite: boolean}>();
const apiByTitle = new Map<string, {id: number, title: string, favorite: boolean}>();
for (const apiNote of apiMetadata) {
const key = `${apiNote.category}/${apiNote.title}`;
apiMap.set(key, { id: apiNote.id, favorite: apiNote.favorite });
const timestampKey = `${apiNote.modified}:${apiNote.category}`;
const titleKey = `${apiNote.category}/${apiNote.title}`;
const noteData = { id: apiNote.id, title: apiNote.title, favorite: apiNote.favorite };
apiByTimestamp.set(timestampKey, noteData);
apiByTitle.set(titleKey, noteData);
}
// Update favorite status in cache for matching notes
for (const cachedNote of cachedNotes) {
const key = `${cachedNote.category}/${cachedNote.title}`;
const apiData = apiMap.get(key);
// Try timestamp match first (most reliable)
const timestampKey = `${cachedNote.modified}:${cachedNote.category}`;
let apiData = apiByTimestamp.get(timestampKey);
// Fallback to title match if timestamp doesn't work
if (!apiData) {
const titleKey = `${cachedNote.category}/${cachedNote.title}`;
apiData = apiByTitle.get(titleKey);
}
if (apiData && cachedNote.favorite !== apiData.favorite) {
console.log(`Updating favorite status for "${cachedNote.title}": ${cachedNote.favorite} -> ${apiData.favorite}`);